fix: disable button tooltips with empty content #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stropitek
reviewed
May 27, 2024
Deploying react-science with
|
| Latest commit: |
efd6246
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://18cf1271.react-science.pages.dev |
| Branch Preview URL: | https://fix-button-tooltip-empty-war.react-science.pages.dev |
Co-authored-by: Daniel Kostro <kostro.d@gmail.com>
hamed-musallam
force-pushed
the
fix-button-tooltip-empty-warning
branch
from
ff85f0c
to
408e63e
Compare
stropitek
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a warning in the console from Blueprint.js when the button component is used with empty tooltip content. To prevent this, we should disable the tooltip if its content is empty, which makes sense since an empty tooltip should be avoided.
I believe Blueprint.js should disable the tooltip by default if the content is empty.